-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(verification): create vertex verifiers [part 1/5] #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor/genesis #796 +/- ##
===================================================
Coverage ? 84.64%
===================================================
Files ? 266
Lines ? 22071
Branches ? 3369
===================================================
Hits ? 18683
Misses ? 2730
Partials ? 658 ☔ View full report in Codecov by Sentry. |
96b93db
to
a0cdd3c
Compare
8f2d608
to
462f90f
Compare
462f90f
to
f35ffce
Compare
a86c175
to
88ef27f
Compare
d43178a
to
1cb8d78
Compare
The base branch was changed.
Depends on #794
Motivation
This is the first PR in a 5-part series of PRs that completely move verification-related code out of the vertex model classes. This series is a continuation of the already merged #779.
In this PR, the module scaffolding introduced in the previous PR is changed to a classes structure that mimics the existing model classes structure. This allows easier incremental migration of code, as the inheritance tree is kept the same. In the future, if we untangle the inherited calls in verification methods, we may convert this back to modules, which would be the ideal solution in my opinion.
Acceptance Criteria
block_verification
,transaction_verification
, andtoken_creation_tx_verification
modules to each respective newVerifier
class. No logic should be changed, only moving module functions to class methods.VertexVerifier
superclass and aVerifier
class forMergeMinedBlock
, completing verifiers for all 4 vertex types, and setting up the same inheritance tree as the vertex class themselves.VerificationService
to receive the newVertexVerifiers
named tuple, for injecting verifiers (this will be useful for the simulator). Also, update methods to use each respective verifier.Builder
andCliBuilder
accordingly.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged