feat(p2p): run periodic bootstrap discovery #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
feat/p2p-periodic-bootstrap-discovery
branch
from
501ce63 to
d544581
Compare
msbrogli
force-pushed
the
feat/p2p-peer-relay
branch
2 times, most recently
from
f994480 to
a6ceae7
Compare
jansegre
force-pushed
the
feat/p2p-periodic-bootstrap-discovery
branch
from
d544581 to
d0f737d
Compare
jansegre
changed the title
jansegre
force-pushed
the
feat/p2p-periodic-bootstrap-discovery
branch
from
d0f737d to
ef28db0
Compare
jansegre
force-pushed
the
feat/p2p-periodic-bootstrap-discovery
branch
from
ef28db0 to
a064ca1
Compare
glevco
approved these changes
Sep 28, 2023
jansegre
force-pushed
the
feat/p2p-periodic-bootstrap-discovery
branch
from
a064ca1 to
c968aea
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
==========================================
- Coverage 84.68% 84.64% -0.04%
==========================================
Files 264 264
Lines 22020 22024 +4
Branches 3367 3367
==========================================
- Hits 18647 18643 -4
- Misses 2721 2727 +6
- Partials 652 654 +2
☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Oct 2, 2023
This was referenced Oct 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The DNS bootstrap mechanism used to run only when there were no longer any connections, however it's better to run it periodically to pick up new DNS records.
Acceptance Criteria
PeerDiscoveryobject fromHathorManagertoConnectionsManagerPEER_DISCOVERY_INTERVALwith interval that discovery should run againChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged