Skip to content

feat(p2p): Add a maximum number of connections per IP address #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Sep 22, 2023

Motivation

Enforcing connection limits per IP Address enhances sybil attack resistance.

Acceptance Criteria

  1. Limit the number of connections per IP address.
  2. Use the address provided by the factory instead of querying the transport.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner September 22, 2023 07:01
@msbrogli msbrogli requested a review from glevco September 22, 2023 07:02
@msbrogli msbrogli self-assigned this Sep 22, 2023
@msbrogli msbrogli added the enhancement New feature or request label Sep 22, 2023
@msbrogli msbrogli changed the base branch from master to feat/p2p-ping-salt September 22, 2023 07:16
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch 3 times, most recently from cf72e8d to 941d9fb Compare September 22, 2023 09:00
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch from 941d9fb to 1e33892 Compare September 22, 2023 16:35
@msbrogli msbrogli force-pushed the feat/p2p-ping-salt branch 2 times, most recently from 2c47a7d to e2d9278 Compare September 22, 2023 18:47
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch from 1e33892 to 8750cd3 Compare September 22, 2023 18:55
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch from 8750cd3 to ce879c5 Compare September 22, 2023 19:11
Base automatically changed from feat/p2p-ping-salt to master September 22, 2023 21:23
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch from ce879c5 to 7a0ccab Compare September 22, 2023 21:26
jansegre
jansegre previously approved these changes Sep 22, 2023
glevco
glevco previously approved these changes Sep 22, 2023
jansegre
jansegre previously approved these changes Sep 22, 2023
@msbrogli msbrogli dismissed stale reviews from jansegre and glevco via 617b327 September 23, 2023 01:08
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch 2 times, most recently from 617b327 to 6289b36 Compare September 23, 2023 02:42
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch 2 times, most recently from 3a99e73 to 65d6615 Compare October 18, 2023 15:56
@jansegre jansegre force-pushed the feat/p2p-max-conn-per-ip branch from 65d6615 to 946e88b Compare October 19, 2023 22:45
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch from 946e88b to 11cfebc Compare October 24, 2023 19:42
@msbrogli msbrogli force-pushed the feat/p2p-max-conn-per-ip branch from 11cfebc to 5eefa17 Compare October 25, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants