Skip to content

feat(reliable-integration): emit VERTEX_METADATA_CHANGED events in reverse topological order #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Sep 21, 2023

Motivation

To help Reliable Integration use cases, it would be better to emit VERTEX_METADATA_CHANGED events in topological order from right to left. This can be achieved by sorting by decreasing transaction timestamp.

Acceptance Criteria

  • Change events emitted from consensus to sorted by reverse timestamp instead of hash

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Sep 21, 2023
@glevco glevco marked this pull request as ready for review September 21, 2023 18:16
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (aadaf75) 84.64% compared to head (68d1edc) 84.74%.
Report is 9 commits behind head on master.

❗ Current head 68d1edc differs from pull request most recent head 57126e4. Consider uploading reports for the commit 57126e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   84.64%   84.74%   +0.10%     
==========================================
  Files         260      259       -1     
  Lines       21951    21939      -12     
  Branches     2965     2964       -1     
==========================================
+ Hits        18581    18593      +12     
+ Misses       2722     2703      -19     
+ Partials      648      643       -5     
Files Coverage Δ
hathor/consensus/consensus.py 97.89% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/reliable-integration/topological-events branch 3 times, most recently from e8c0794 to e3b457e Compare September 26, 2023 15:03
@glevco glevco force-pushed the feat/reliable-integration/topological-events branch from e3b457e to 57126e4 Compare September 27, 2023 15:23
@jansegre jansegre merged commit 0e18dd4 into master Sep 27, 2023
@jansegre jansegre deleted the feat/reliable-integration/topological-events branch September 27, 2023 17:55
This was referenced Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants