Skip to content

fix(feature-activation): add signal bits to minimally valid block #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Sep 20, 2023

Motivation

The BlockTemplate.generate_minimally_valid_block() method is not setting signal bits as it should.

Acceptance Criteria

  • Add signal bits to minimally valid block template

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Sep 20, 2023
@glevco glevco marked this pull request as ready for review September 20, 2023 02:22
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (68d1edc) 84.74% compared to head (fa6efd5) 84.67%.
Report is 11 commits behind head on master.

❗ Current head fa6efd5 differs from pull request most recent head 1360614. Consider uploading reports for the commit 1360614 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
- Coverage   84.74%   84.67%   -0.08%     
==========================================
  Files         259      259              
  Lines       21939    21931       -8     
  Branches     2964     2964              
==========================================
- Hits        18593    18570      -23     
- Misses       2703     2712       +9     
- Partials      643      649       +6     
Files Coverage Δ
hathor/mining/block_template.py 94.33% <100.00%> (ø)

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

msbrogli
msbrogli previously approved these changes Sep 20, 2023
@glevco glevco force-pushed the fix/feature-activation/signal-bits branch from fa6efd5 to b817c5b Compare September 20, 2023 15:53
@glevco glevco force-pushed the fix/feature-activation/signal-bits branch from 72c3078 to afe911a Compare September 20, 2023 16:10
@glevco glevco requested a review from msbrogli September 20, 2023 16:11
@glevco glevco force-pushed the fix/feature-activation/signal-bits branch 4 times, most recently from 405ba77 to 827dc21 Compare September 27, 2023 15:32
@glevco glevco force-pushed the fix/feature-activation/signal-bits branch from 827dc21 to 1360614 Compare September 27, 2023 17:58
@jansegre jansegre merged commit 427a128 into master Sep 28, 2023
@jansegre jansegre deleted the fix/feature-activation/signal-bits branch September 28, 2023 14:15
This was referenced Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants