-
Notifications
You must be signed in to change notification settings - Fork 29
refactor: move simulator utils functions #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 85.16% 85.22% +0.06%
==========================================
Files 284 285 +1
Lines 22576 22655 +79
Branches 3430 3444 +14
==========================================
+ Hits 19226 19308 +82
Misses 2667 2667
+ Partials 683 680 -3
☔ View full report in Codecov by Sentry. |
eda0545
to
e672226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Two minor points:
- This should probably be named a refactor;
- Should we add a linter check to prevent
from tests* import
orimport tests*
?
f383165
to
2dbc6b3
Compare
85c5ae3
to
7e2d1af
Compare
@jansegre both done! |
7e2d1af
to
fc27813
Compare
fc27813
to
6bd92a1
Compare
050373e
to
4c436e3
Compare
4c436e3
to
c2e4593
Compare
1981890
to
1d4c04c
Compare
1d4c04c
to
f093a77
Compare
Converted to draft as we wait other PRs to be merged before this one. |
f093a77
to
cacba12
Compare
cacba12
to
5a38b60
Compare
Motivation
The events simulator CLI tool was using some functions defined in the
tests
module, which is not copied to the Docker image. To make the tool available via Docker, those functions must be moved to another module.Acceptance Criteria
tests
module toutils/simulator
moduletests
are not imported inhathor
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged