Skip to content

refactor(sync-v2): rename SyncAgent module from manager to agent #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Aug 4, 2023

Motivation

After the last refactor this module name was left unchanged.

Acceptance Criteria

  • Rename hathor.p2p.sync_v2.manager module to hathor.p2p.sync_v2.agent adjusting all the references.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Aug 4, 2023
@jansegre jansegre requested a review from msbrogli as a code owner August 4, 2023 15:23
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #748 (413a42c) into master (a63ab5f) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 413a42c differs from pull request most recent head 4277cc2. Consider uploading reports for the commit 4277cc2 to get more accurate results

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   84.57%   84.48%   -0.09%     
==========================================
  Files         253      253              
  Lines       21708    21706       -2     
  Branches     2941     2941              
==========================================
- Hits        18359    18338      -21     
- Misses       2710     2724      +14     
- Partials      639      644       +5     
Files Changed Coverage Δ
hathor/p2p/sync_v2/agent.py 74.38% <ø> (ø)
hathor/p2p/sync_v2/mempool.py 94.11% <ø> (ø)
hathor/p2p/sync_v2/streamers.py 88.41% <ø> (ø)
hathor/p2p/sync_v2/factory.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@jansegre jansegre requested review from glevco and pedroferreira1 and removed request for glevco August 8, 2023 13:40
@jansegre jansegre force-pushed the refactor/sync-v2-agent branch from 413a42c to 4277cc2 Compare August 8, 2023 13:55
@jansegre jansegre merged commit 97f2471 into master Aug 8, 2023
@jansegre jansegre deleted the refactor/sync-v2-agent branch August 8, 2023 16:09
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants