chore: improve merkle path log #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
approved these changes
Aug 3, 2023
msbrogli
approved these changes
Aug 3, 2023
glevco
force-pushed
the
chore/improve-merkle-log
branch
from
16ae183 to
d66a08c
Compare
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 84.56% 84.54% -0.02%
==========================================
Files 252 252
Lines 21688 21689 +1
Branches 2937 2937
==========================================
- Hits 18341 18338 -3
- Misses 2709 2712 +3
- Partials 638 639 +1
|
glevco
force-pushed
the
chore/improve-merkle-log
branch
from
d66a08c to
afddefe
Compare
This was referenced Aug 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the error log of a merkle path length when it's higher than the maximum allowed.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged