-
Notifications
You must be signed in to change notification settings - Fork 29
feat(feature-activation): implement signal bits in mining blocks #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2287889
to
037b4b4
Compare
81ed4ee
to
3f4121e
Compare
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
+ Coverage 84.62% 84.67% +0.04%
==========================================
Files 253 252 -1
Lines 21708 21770 +62
Branches 2941 2948 +7
==========================================
+ Hits 18371 18434 +63
+ Misses 2702 2690 -12
- Partials 635 646 +11
|
8c7be67
to
4ab2466
Compare
3f4121e
to
822f28e
Compare
4ab2466
to
1092ff1
Compare
4b6fccc
to
04e19ae
Compare
1 task
0519850
to
9176efb
Compare
04e19ae
to
ff3f384
Compare
Base automatically changed from
feat/feature-activation/bit-signaling-service
to
master
July 19, 2023 19:35
39d35ba
to
268d8bc
Compare
268d8bc
to
ad71fdf
Compare
jansegre
approved these changes
Jul 21, 2023
ad71fdf
to
152e935
Compare
152e935
to
3c5c3ca
Compare
msbrogli
approved these changes
Aug 4, 2023
3c5c3ca
to
450e622
Compare
450e622
to
c3361c8
Compare
1 task
c3361c8
to
f89cd71
Compare
This was referenced Aug 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements the
BitSignalingService
usage as defined in this RFC.Acceptance Criteria
BlockTemplate.signal_bits
attributeBitSignalingService
toHathorManager
and use it to injectsignal_bits
into mining blocksBuilder
andCliBuilder
Builder.set_settings()
method, which is useful for testingChecklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged