Skip to content

feat(feature-activation): implement signal bits in mining blocks #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jul 14, 2023

Motivation

This PR implements the BitSignalingService usage as defined in this RFC.

Acceptance Criteria

  • Add BlockTemplate.signal_bits attribute
  • Add BitSignalingService to HathorManager and use it to inject signal_bits into mining blocks
  • Add Feature Activation related methods to Builder and CliBuilder
  • Add Builder.set_settings() method, which is useful for testing

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 14, 2023
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 2287889 to 037b4b4 Compare July 14, 2023 19:42
@glevco glevco changed the title feat(feature-activation): implement bit signal in block templates feat(feature-activation): implement signal bits in block templates Jul 14, 2023
@glevco glevco changed the title feat(feature-activation): implement signal bits in block templates feat(feature-activation): implement signal bits in mining blocks Jul 14, 2023
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch 2 times, most recently from 81ed4ee to 3f4121e Compare July 17, 2023 17:03
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #703 (f89cd71) into master (4277cc2) will increase coverage by 0.04%.
Report is 4 commits behind head on master.
The diff coverage is 81.11%.

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   84.62%   84.67%   +0.04%     
==========================================
  Files         253      252       -1     
  Lines       21708    21770      +62     
  Branches     2941     2948       +7     
==========================================
+ Hits        18371    18434      +63     
+ Misses       2702     2690      -12     
- Partials      635      646      +11     
Files Changed Coverage Δ
hathor/p2p/utils.py 73.87% <66.66%> (-1.40%) ⬇️
hathor/simulator/fake_connection.py 83.42% <70.00%> (-0.76%) ⬇️
hathor/builder/builder.py 91.51% <80.00%> (-1.49%) ⬇️
hathor/builder/cli_builder.py 74.48% <100.00%> (+0.53%) ⬆️
hathor/manager.py 82.76% <100.00%> (+0.07%) ⬆️
hathor/mining/block_template.py 94.33% <100.00%> (+5.87%) ⬆️
hathor/p2p/resources/status.py 100.00% <100.00%> (ø)
hathor/p2p/states/ready.py 93.89% <100.00%> (-0.05%) ⬇️
hathor/simulator/miner/geometric_miner.py 100.00% <100.00%> (ø)
hathor/transaction/base_transaction.py 93.99% <100.00%> (+<0.01%) ⬆️

... and 5 files with indirect coverage changes

@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from 8c7be67 to 4ab2466 Compare July 18, 2023 01:09
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 3f4121e to 822f28e Compare July 18, 2023 01:13
@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from 4ab2466 to 1092ff1 Compare July 18, 2023 16:44
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch 2 times, most recently from 4b6fccc to 04e19ae Compare July 18, 2023 23:16
@glevco glevco force-pushed the feat/feature-activation/bit-signaling-service branch from 0519850 to 9176efb Compare July 19, 2023 17:47
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 04e19ae to ff3f384 Compare July 19, 2023 17:48
Base automatically changed from feat/feature-activation/bit-signaling-service to master July 19, 2023 19:35
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 39d35ba to 268d8bc Compare July 19, 2023 19:42
@glevco glevco marked this pull request as ready for review July 19, 2023 19:43
@glevco glevco requested review from jansegre and msbrogli as code owners July 19, 2023 19:43
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 268d8bc to ad71fdf Compare July 20, 2023 16:54
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from ad71fdf to 152e935 Compare July 26, 2023 20:04
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 152e935 to 3c5c3ca Compare August 3, 2023 22:06
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 3c5c3ca to 450e622 Compare August 7, 2023 22:49
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from 450e622 to c3361c8 Compare August 21, 2023 22:17
@glevco glevco force-pushed the feat/feature-activation/bit-signal-templates branch from c3361c8 to f89cd71 Compare August 23, 2023 17:48
@jansegre jansegre merged commit 88eeb5c into master Aug 23, 2023
@jansegre jansegre deleted the feat/feature-activation/bit-signal-templates branch August 23, 2023 20:40
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants