fix(nano): non-idempotent indexes handling

[glevco]

Motivation

There's a bug in the index handling of nano contracts. There's a method called nc_update_add() in the IndexesManager that updates indexes according to contract's actions and executed syscalls. This method was called in the update() method of that class every time the nano tx was affected by an update in the consensus. Instead, it should be called only once, when the contract executes.

Without this fix, index handling would happen more than once, which is problematic for some syscalls. For example, if a contract creates a token TKA, the amount of TKA is added to the tokens index and the amount of HTR deposit is removed. When the tx is spent, it would be considered a txs_affected in the consensus, causing the index to be updated again. This would drift the index values away from the expected ones, doubling the amount of created TKA and deposited HTR.

Acceptance Criteria

• Move IndexesManager.nc_update_add call from IndexesManager.update to BlockConsensusAlgorithm._nc_execute_calls.
• Rename IndexesManager.nc_update_add to handle_contract_execution and nc_update_remove to handle_contract_unexecution.
• Add a test that fails on master, but passes on this branch.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[github-actions]

Bencher Report

Branch	fix/nano/indexes
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result minutes (m) (Result Δ%)	Lower Boundary minutes (m) (Limit %)	Upper Boundary minutes (m) (Limit %)
sync-v2 (up to 20000 blocks)	📈 view plot 🚷 view threshold	1.63 m (-0.51%) Baseline: 1.64 m	1.47 m (90.46%)	1.80 m (90.44%)

🐰 View full continuous benchmarking report in Bencher

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.61%. Comparing base (5aa5543) to head (4ce6c0b).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   85.62%   85.61%   -0.02%     
==========================================
  Files         426      426              
  Lines       31948    31947       -1     
  Branches     4965     4962       -3     
==========================================
- Hits        27355    27350       -5     
- Misses       3595     3597       +2     
- Partials      998     1000       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.