chore: add reorg log #1253
Open
chore: add reorg log #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | chore/log-reorg |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.65 m(+1.07%)Baseline: 1.63 m | 1.47 m (89.05%) | 1.80 m (91.88%) |
jansegre
approved these changes
Apr 1, 2025
msbrogli
approved these changes
Apr 1, 2025
| @@ -135,12 +135,26 @@ def unsafe_update(self, base: BaseTransaction) -> None: | |||
| assert isinstance(old_best_block, Block) | |||
| new_best_block = base.storage.get_transaction(new_best_tip) | |||
| reorg_size = old_best_block.get_height() - context.reorg_common_block.get_height() | |||
| # TODO: After we remove block ties, should the assert below be true? | |||
| # assert old_best_block.get_metadata().voided_by | |||
There was a problem hiding this comment.
I don't understand why it would not be true even with block ties.
There was a problem hiding this comment.
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1253 +/- ##
==========================================
- Coverage 84.22% 84.12% -0.11%
==========================================
Files 311 311
Lines 23868 23869 +1
Branches 3651 3651
==========================================
- Hits 20103 20079 -24
- Misses 3055 3071 +16
- Partials 710 719 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be useful to track reorgs via full node logs.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged