chore(events): remove event queue from unsafe mode #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
chore/safe-event-queue
branch
from
ca53292 to
9b06b7e
Compare
|
Bencher Report| Branch | chore/safe-event-queue |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency nanoseconds (ns) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 86,479,138,708.94 (-13.66%) | 90,145,910,345.65 (104.24%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 86,479,138,708.94 (-13.66%) | 90,145,910,345.65 (104.24%) | 110,178,334,866.90 (78.49%) |
glevco
force-pushed
the
chore/safe-event-queue
branch
from
9b06b7e to
00fe9d9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
- Coverage 84.96% 84.91% -0.06%
==========================================
Files 323 323
Lines 25044 25046 +2
Branches 3846 3847 +1
==========================================
- Hits 21279 21268 -11
- Misses 3026 3037 +11
- Partials 739 741 +2 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Dec 4, 2024
jansegre
approved these changes
Dec 4, 2024
This was referenced Dec 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Event Queue feature has been used for a while now by the Wallet Service, so we can remove it from unsafe/experimental mode.
Acceptance Criteria
--x-enable-event-queuefrom unsafe mode.--enable-event-queueand warning to deprecate--x-enable-event-queue.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged