-
Notifications
You must be signed in to change notification settings - Fork 29
feat(dag-builder): Add a tool to generate vertices from a DAG description #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
232bc3e
to
4e2813c
Compare
4e2813c
to
1f57b7e
Compare
|
Branch | feat/dag-builder |
Testbed | ubuntu-22.04 |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 103,989,761,030.36 (+1.63%) | 92,089,692,645.99 (88.56%) | 112,554,068,789.54 (92.39%) |
7b52412
to
5b0be7f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
+ Coverage 84.86% 84.89% +0.03%
==========================================
Files 314 322 +8
Lines 24335 24970 +635
Branches 3708 3833 +125
==========================================
+ Hits 20652 21199 +547
- Misses 2974 3034 +60
- Partials 709 737 +28 ☔ View full report in Codecov by Sentry. |
321c91c
to
d8ad4d5
Compare
jansegre
reviewed
Nov 11, 2024
3385aaf
to
df9d0e6
Compare
glevco
reviewed
Nov 11, 2024
c4b256d
to
c7512e8
Compare
c90b105
to
f24ba29
Compare
33fdc20
to
f5b1de5
Compare
glevco
previously approved these changes
Nov 13, 2024
f5b1de5
to
d0e699c
Compare
jansegre
previously approved these changes
Nov 14, 2024
f58e81f
to
fda29c6
Compare
jansegre
previously approved these changes
Nov 14, 2024
glevco
previously approved these changes
Nov 14, 2024
fda29c6
to
d76d190
Compare
d76d190
to
203b2ba
Compare
203b2ba
to
3a38194
Compare
glevco
approved these changes
Nov 14, 2024
jansegre
approved these changes
Nov 14, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Manually generating DAGs for tests is overly verbose and lacks readability. Testers need to focus on the higher-level test objectives without getting bogged down in transaction creation details. So this PR introduces a DSL to describe DAGs and a tool to generate a list of vertices that fulfill the DAG description.
Acceptance Criteria
cli.py
that outputs a file format compatible withload_from_logs
cli command.tests.unittest.TestCase.get_dag_builder()
that creates a DAG builder from aHathorManager
object.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged