refactor(p2p): refactor peer address handling [part 1/10] #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | refactor/p2p/peer-address-handling |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,436,141,142.24 (-0.36%) | 91,619,769,898.77 (90.32%) | 111,979,718,765.16 (90.58%) |
glevco
changed the title
glevco
changed the title
1 task
msbrogli
approved these changes
Nov 6, 2024
jansegre
approved these changes
Nov 6, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the P2P Multiprocess project, this PR implements refactors to improve the way we handle peer addresses.
Acceptance Criteria
WarningFlags.NO_PEER_ID_URL.FakeConnectionandHathorStringTransportso they support real addresses.FakeConnectionso it actually callsConnectionsManager.connect_toto make a connection, instead of just manually creating a connection that was not properly started by that method.PeerAddressdataclass and renameEntrypointdataclass toPeerEndpoint, which is now composed by the newPeerAddressand aPeerId.PeerInfo.entrypointsto a list ofPeerAddressinstead ofPeerEndpoint.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged