Skip to content

fix(ws): Fix tx history streamer wrong logging when pauseProducing() is called multiple times #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Sep 10, 2024

Motivation

Twisted can call pauseProducing() multiple times before calling resumeProducing(). This transition from PAUSED to PAUSED was not expected and it was generating a wrong warning log message.

Acceptance Criteria

  1. Allow transition PAUSED -> PAUSED which actually does nothing.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner September 10, 2024 16:47
@msbrogli msbrogli requested a review from r4mmer September 10, 2024 16:47
@msbrogli msbrogli self-assigned this Sep 10, 2024
Copy link

🐰Bencher

ReportTue, September 10, 2024 at 16:50:19 UTC
Projecthathor-core
Branchfix/tx-history-streamer-paused
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,380,056,013.80 (-0.69%)91,877,624,945.93 (90.63%)112,294,874,933.91 (90.28%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@msbrogli msbrogli merged commit 9fddd7a into master Sep 10, 2024
11 of 12 checks passed
@msbrogli msbrogli deleted the fix/tx-history-streamer-paused branch September 10, 2024 16:57
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (e26a841) to head (9fddd7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
+ Coverage   84.27%   84.42%   +0.14%     
==========================================
  Files         317      317              
  Lines       24291    24291              
  Branches     3696     3696              
==========================================
+ Hits        20471    20507      +36     
+ Misses       3093     3068      -25     
+ Partials      727      716      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants