chore: upgrade actions to a version that use node20 (LTS) #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Report | Wed, August 21, 2024 at 19:13:12 UTC |
| Project | hathor-core |
| Branch | chore/upgrade-lts-node-actions |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,384,972,728.80 (-1.46%) | 82,313,370,976.82 (81.19%) | 123,470,056,465.23 (82.11%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 84.88% 84.87% -0.01%
==========================================
Files 315 315
Lines 24071 24071
Branches 3647 3647
==========================================
- Hits 20432 20431 -1
Misses 2927 2927
- Partials 712 713 +1 ☔ View full report in Codecov by Sentry. |
tuliomir
approved these changes
Aug 21, 2024
jansegre
approved these changes
Aug 21, 2024
r4mmer
force-pushed
the
chore/upgrade-lts-node-actions
branch
from
4e80356 to
4904543
Compare
r4mmer
force-pushed
the
chore/upgrade-lts-node-actions
branch
from
4904543 to
0796676
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some workflows were giving warnings that they were using actions running on node16 and node16 has reached EOL for almost a year.
For now all node16 runners are forced to run on node20 and this behavior will be set to fail the action in a few months.
Github announcement
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged