refactor(p2p): use PeerId type instead of str #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
approved these changes
Aug 20, 2024
jansegre
force-pushed
the
refactor/p2p-rename-peer-id
branch
2 times, most recently
from
945e51d to
eb6c3d7
Compare
jansegre
force-pushed
the
refactor/p2p-peer-use-peer-id
branch
from
9c218c4 to
255b1d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 84.83% 84.88% +0.05%
==========================================
Files 315 316 +1
Lines 24071 24079 +8
Branches 3647 3645 -2
==========================================
+ Hits 20421 20440 +19
+ Misses 2936 2924 -12
- Partials 714 715 +1 ☔ View full report in Codecov by Sentry. |
glevco
previously approved these changes
Aug 22, 2024
msbrogli
previously approved these changes
Aug 22, 2024
jansegre
force-pushed
the
refactor/p2p-rename-peer-id
branch
from
eb6c3d7 to
f2c436f
Compare
jansegre
dismissed stale reviews from msbrogli and glevco
The base branch was changed.
jansegre
force-pushed
the
refactor/p2p-peer-use-peer-id
branch
from
255b1d4 to
ada19b8
Compare
glevco
approved these changes
Aug 22, 2024
|
| Report | Thu, August 22, 2024 at 14:47:51 UTC |
| Project | hathor-core |
| Branch | refactor/p2p-peer-use-peer-id |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 104,022,524,163.80 (+0.99%) | 92,698,520,376.58 (89.11%) | 113,298,191,571.37 (91.81%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
msbrogli
approved these changes
Aug 22, 2024
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the second refactor in this series. It makes it so
Peer.idis aPeerIdinstead of astr, that way it is already checked to be a valid hash.Acceptance Criteria
hathor.p2p.peer.Peer.idfromstrtohathor.p2p.peer_id.PeerIdChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged