chore(benchmark): improve benchmark CI #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
chore/improve-bench
branch
4 times, most recently
from
c8ba3e6 to
fcd9dff
Compare
|
| Report | Mon, August 19, 2024 at 16:13:19 UTC |
| Project | hathor-core |
| Branch | chore/improve-bench |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,650,896,060.40 (-1.68%) | 82,708,741,756.12 (81.37%) | 124,063,112,634.18 (81.93%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
glevco
force-pushed
the
chore/improve-bench
branch
from
fcd9dff to
ce1d899
Compare
jansegre
approved these changes
Aug 19, 2024
msbrogli
approved these changes
Aug 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
+ Coverage 84.91% 84.93% +0.01%
==========================================
Files 315 315
Lines 24070 24070
Branches 3647 3647
==========================================
+ Hits 20439 20443 +4
+ Misses 2921 2918 -3
+ Partials 710 709 -1 ☔ View full report in Codecov by Sentry. |
1 task
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Benchmark on CI was sometimes failing when the server node would take some time to start sending blocks to the benchmark node, causing an increase in the measured time. Adding a warmup run to hyperfine fix this as it is discarded, and then the two following runs are valid.
I also noticed the large waiting times for the download step (20 min) was caused by cache not being set in the full node. I added it and it now takes 2 min.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged