Skip to content

fix: healthcheck content-type #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: healthcheck content-type #1110

merged 1 commit into from
Aug 22, 2024

Conversation

luislhl
Copy link
Collaborator

@luislhl luislhl commented Aug 19, 2024

Motivation

We are getting an error from aiohttp in explorer-service when trying to get /health from hathor-core and parse it as json.

Acceptance Criteria

  • The /health endpoint should use the correct Content-Type which should be application/json, instead of text/html

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@luislhl luislhl force-pushed the fix/healthcheck-content-type branch from 95fe33e to b9b67c5 Compare August 19, 2024 01:57
@luislhl luislhl self-assigned this Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportThu, August 22, 2024 at 19:30:56 UTC
Projecthathor-core
Branchfix/healthcheck-content-type
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)104,042,467,308.64 (+1.27%)92,461,354,314.26 (88.87%)113,008,321,939.65 (92.07%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.63%. Comparing base (f6ddf3c) to head (a0e3210).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
- Coverage   84.64%   84.63%   -0.02%     
==========================================
  Files         317      317              
  Lines       24149    24150       +1     
  Branches     3665     3665              
==========================================
- Hits        20441    20439       -2     
- Misses       3002     3005       +3     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luislhl luislhl force-pushed the fix/healthcheck-content-type branch from 9880491 to 8f8f97e Compare August 20, 2024 19:42
@luislhl luislhl enabled auto-merge (squash) August 22, 2024 19:27
@luislhl luislhl force-pushed the fix/healthcheck-content-type branch from 8f8f97e to a0e3210 Compare August 22, 2024 19:28
@luislhl luislhl merged commit da32f80 into master Aug 22, 2024
13 checks passed
@luislhl luislhl deleted the fix/healthcheck-content-type branch August 22, 2024 20:51
@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants