Skip to content

fix: fix timestamps on gen-genesis CLI #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jul 25, 2024

Motivation

There's a bug in the gen-genesis CLI tool where the timestamps are changed when the genesis weights are greater than zero.

Acceptance Criteria

  • Set update_time=False on genesis generation.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Jul 25, 2024
@glevco glevco self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (716a012) to head (bda7fb0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   85.11%   85.05%   -0.07%     
==========================================
  Files         314      314              
  Lines       23957    23957              
  Branches     3621     3621              
==========================================
- Hits        20392    20377      -15     
- Misses       2862     2872      +10     
- Partials      703      708       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the fix/gen-genesis-timestamps branch from 8181dcf to bda7fb0 Compare July 30, 2024 15:44
@glevco glevco marked this pull request as ready for review July 30, 2024 15:44
@glevco glevco requested review from jansegre and msbrogli as code owners July 30, 2024 15:44
@glevco glevco merged commit dcb876c into master Jul 30, 2024
12 checks passed
@glevco glevco deleted the fix/gen-genesis-timestamps branch July 30, 2024 18:30
@glevco glevco added this to the Test Gabriel milestone Aug 8, 2024
@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants