Skip to content

fix(logging): make different version logging less obtrusive #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jansegre
Copy link
Member

Motivation

Different version log is unnecessarily a warning.

Acceptance Criteria

  • Change from log.warn to log.debug.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from msbrogli and glevco July 18, 2024 16:21
@jansegre jansegre self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.98%. Comparing base (a77deb3) to head (eb74c11).

Files Patch % Lines
hathor/p2p/states/hello.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
+ Coverage   84.90%   84.98%   +0.08%     
==========================================
  Files         310      310              
  Lines       23493    23495       +2     
  Branches     3549     3549              
==========================================
+ Hits        19947    19968      +21     
+ Misses       2838     2824      -14     
+ Partials      708      703       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the fix/version-logging branch from 396f3cd to eb74c11 Compare July 18, 2024 19:43
@jansegre jansegre merged commit 1aeb710 into master Jul 18, 2024
12 checks passed
@jansegre jansegre deleted the fix/version-logging branch July 18, 2024 22:53
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants