refactor(settings): more settings injection refactors #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/settings-injection
branch
from
94ccef5 to
a234b36
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 308 308
Lines 23295 23303 +8
Branches 3518 3518
=======================================
+ Hits 19727 19734 +7
- Misses 2863 2865 +2
+ Partials 705 704 -1 ☔ View full report in Codecov by Sentry. |
1 task
jansegre
approved these changes
Jul 16, 2024
msbrogli
approved these changes
Jul 16, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Continue refactoring
HathorSettingsusages to use an injected instance rather than global.Acceptance Criteria
BaseIndex,MemoryIndexesManager, andMemoryHeightIndex.BaseTransactionand all its subclasses, andTransactionMetadata.get_deposit_amount()andget_withdraw_amount()functions.TransactionStorageto inject its settings into constructed genesis.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged