Skip to content

fix(cli): regression of --help after side-dag cli #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jansegre
Copy link
Member

Motivation

After #1039 using python -m hathor run_node --help shows an unrelated help display. This wasn't caught during review or by any tests. We should add tests for cli display in the future, although this PR only fixes the immediate problem.

Acceptance Criteria

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested a review from glevco June 21, 2024 15:35
@jansegre jansegre self-assigned this Jun 21, 2024
@jansegre jansegre requested a review from msbrogli as a code owner June 21, 2024 15:35
@jansegre jansegre requested a review from pedroferreira1 June 21, 2024 15:35
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (4a46f3a) to head (bc01626).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
+ Coverage   84.88%   84.93%   +0.04%     
==========================================
  Files         300      300              
  Lines       22944    22944              
  Branches     3471     3471              
==========================================
+ Hits        19476    19487      +11     
+ Misses       2777     2772       -5     
+ Partials      691      685       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre merged commit 14289d5 into master Jun 21, 2024
12 checks passed
@jansegre jansegre deleted the fix/run-node-help-regression branch June 21, 2024 16:02
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants