Skip to content

fix(side-dag): remove init timeout #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 17, 2024

Motivation

The new run_node_with_side_dag command timed out in 10 seconds if the Hathor node did not start. This was incorrect because when loading from an existing storage, the Hathor node will always take more than 10 seconds to initialize.

This PR removes the timeout and simply waits indefinitely until the Hathor node is either ready or errored. This will be further improved when the monitor process is implemented (see #1051).

Acceptance Criteria

  • Remove Hathor node init timeout in favor of waiting.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Jun 17, 2024
@glevco glevco self-assigned this Jun 17, 2024
@glevco glevco requested review from jansegre and msbrogli as code owners June 17, 2024 16:32
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (255fd58) to head (d5d198b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
+ Coverage   84.90%   84.92%   +0.02%     
==========================================
  Files         300      300              
  Lines       22936    22936              
  Branches     3471     3471              
==========================================
+ Hits        19473    19479       +6     
+ Misses       2774     2769       -5     
+ Partials      689      688       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the fix/side-dag/init-timeout branch from d3889b0 to 6cee55f Compare July 5, 2024 17:55
@glevco glevco force-pushed the fix/side-dag/init-timeout branch from 6cee55f to d5d198b Compare July 5, 2024 18:53
@glevco glevco merged commit c075d5e into master Jul 5, 2024
12 checks passed
@glevco glevco deleted the fix/side-dag/init-timeout branch July 5, 2024 23:23
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants