Skip to content

fix: add peers api #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: add peers api #1052

merged 1 commit into from
Jun 4, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 4, 2024

Motivation

There is a bug in the add peers API after a refactor to use async/await syntax. This PR fixes it.

Acceptance Criteria

  • Add a fire and forget mechanism to the coroutine in the add peers API.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Jun 4, 2024
@glevco glevco requested a review from luislhl June 4, 2024 21:47
@glevco glevco self-assigned this Jun 4, 2024
@glevco glevco marked this pull request as ready for review June 4, 2024 21:47
@glevco glevco requested review from jansegre and msbrogli as code owners June 4, 2024 21:47
@msbrogli msbrogli merged commit 40a25dc into master Jun 4, 2024
10 of 11 checks passed
@msbrogli msbrogli deleted the fix/add-peers-api branch June 4, 2024 22:10
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants