Skip to content

feat(cli): Add --log-vertex-bytes for debugging #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented May 9, 2024

Motivation

We faced some difficulties replicating issue reports from developers. So this PR introduces a parameter to make replication easier just by sharing the full node log with us.

Acceptance Criteria

  • Add the --log-vertex-bytes parameter in the run_node cli.
  • Add the VertexHandler._log_vertex_bytes: bool which defaults to false.
  • Log the transaction bytes when this new option is enabled.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner May 9, 2024 23:01
@msbrogli msbrogli requested a review from glevco May 9, 2024 23:01
@msbrogli msbrogli self-assigned this May 9, 2024
@msbrogli msbrogli added the enhancement New feature or request label May 9, 2024
@msbrogli msbrogli force-pushed the feat/log-vertex-bytes branch from 31d8f3f to 8828816 Compare May 9, 2024 23:05
glevco
glevco previously approved these changes May 9, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.89%. Comparing base (75605be) to head (9b1c03e).

Files Patch % Lines
hathor/vertex_handler/vertex_handler.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   84.89%   84.89%   -0.01%     
==========================================
  Files         297      297              
  Lines       22910    22913       +3     
  Branches     3464     3465       +1     
==========================================
+ Hits        19449    19451       +2     
+ Misses       2775     2773       -2     
- Partials      686      689       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jansegre
jansegre previously approved these changes May 20, 2024
Copy link
Member

@jansegre jansegre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think it's fine for it to be a regular argument instead (no -x).

@msbrogli msbrogli force-pushed the feat/log-vertex-bytes branch from 3a0c176 to 9b1c03e Compare May 28, 2024 15:10
@msbrogli msbrogli changed the title feat(cli): Add --x-log-vertex-bytes for debugging and issue report feat(cli): Add --log-vertex-bytes for debugging May 28, 2024
@msbrogli msbrogli merged commit 9b1c03e into master May 28, 2024
12 checks passed
@msbrogli msbrogli deleted the feat/log-vertex-bytes branch May 28, 2024 17:03
This was referenced May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants