-
Notifications
You must be signed in to change notification settings - Fork 29
feat(cli): Add --log-vertex-bytes for debugging #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
31d8f3f
to
8828816
Compare
8828816
to
a9640b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
- Coverage 84.89% 84.89% -0.01%
==========================================
Files 297 297
Lines 22910 22913 +3
Branches 3464 3465 +1
==========================================
+ Hits 19449 19451 +2
+ Misses 2775 2773 -2
- Partials 686 689 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I think it's fine for it to be a regular argument instead (no -x
).
a9640b8
to
3a0c176
Compare
3a0c176
to
9b1c03e
Compare
Motivation
We faced some difficulties replicating issue reports from developers. So this PR introduces a parameter to make replication easier just by sharing the full node log with us.
Acceptance Criteria
--log-vertex-bytes
parameter in the run_node cli.VertexHandler._log_vertex_bytes: bool
which defaults to false.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged