Skip to content

chore(cli): default to sync-v1 disabled #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

jansegre
Copy link
Member

Motivation

As part of the sync-v2 roll out process we should have a release where sync-v1 is not enabled by default but is still fully supported.

Acceptance Criteria

  • Change the default behavior from having both sync-v1 and sync-v2 enabled to having only sync-v2 enabled but still allow sync-v1 to be enabled at runtime by default.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from msbrogli and glevco April 29, 2024 16:27
@jansegre jansegre self-assigned this Apr 29, 2024
glevco
glevco previously approved these changes Apr 29, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (e06d1d4) to head (cf20125).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   84.99%   84.86%   -0.14%     
==========================================
  Files         298      298              
  Lines       22952    22952              
  Branches     3466     3466              
==========================================
- Hits        19509    19479      -30     
- Misses       2761     2780      +19     
- Partials      682      693      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the chore/default-sync-v1-disable branch from 3bfffdc to cf20125 Compare May 2, 2024 15:45
@jansegre jansegre merged commit dc7071e into master May 2, 2024
@jansegre jansegre deleted the chore/default-sync-v1-disable branch May 2, 2024 21:09
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants