Skip to content

Added support for natbib citation commands #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2018
Merged

Conversation

HannahSchellekens
Copy link
Member

@HannahSchellekens HannahSchellekens commented Nov 7, 2018

This PR addresses and resolves #743.

Additions

  • Added \citet, \citep, \citeauthor and other related natbib commands to the autocomplete.

Changes

  • Made LatexCollapseCiteInspection regard the new commands and collapse only when the same command is chained.
  • Fixed LatexUnresolvedReferenceInspection not taking optional arguments and stars into account when highlighting.

Pictures

image

image

image

image

I split the references Magic set into label/bibitem containing all the
commands that reference labels/bibitems respectively.
TeXiFy now detects whenever multiple of the same type of cite commands
(in all varieties) can be collapsed. The quick fix is adjusted to
also use that certain cite variety. It also recognises stars.
…he right location.

Now it also recognises stars and optional parameters.
@HannahSchellekens HannahSchellekens added the enhancement New feature or (non bug related) change to the program. label Nov 7, 2018
@HannahSchellekens HannahSchellekens added this to the b0.6.2 milestone Nov 7, 2018
@HannahSchellekens HannahSchellekens self-assigned this Nov 7, 2018
Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or (non bug related) change to the program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

citep doesn't suggest references
2 participants