Add reschedule functionality to BackgroundJob #2165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odinserj
reviewed
Feb 16, 2023
There was a problem hiding this comment.
Thanks for the changes, look good to me. Since they don't break anything and quite simple, I can schedule this to 1.7.34 version. However may I ask you to make 2 slight changes to the PR?
- Rename
RequeuetoReschedulein two places in theBackgroundJobclass. - Use 4 spaces instead of 2 in the changed lines.
|
Thanks @odinserj for the quick reply! I made the changes you suggested, let me know if I missed something or if there's any other changes you'd like :)! |
|
@chrischu, may I also ask you to base changes on the |
chrischu
force-pushed
the
feature/AddReschedule
branch
from
d92762d to
061ba2e
Compare
|
Done! |
|
This feature changed the problem in #1976 ? The state got too big in my database |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability to reschedule jobs (similar to the requeue functionality) so we decided to contribute the code. I hope that's ok. Hopefully I added all the necessary tests, if not please let me know :).