NPM 5 #8766
NPM 5 #8766
Conversation
|
Should be ready |
|
@SabreCat do you have an idea why the API tests are failing this way? I cannot find what would cause this |
|
That is strange. o.O I'll see what I can figure out, but @TheHollidayInn might also be a good person to ask! |
|
Soo the problem isn't NPM5 but the newest release of Mongoose which introduced a sort of breaking change regarding the error message Automattic/mongoose#5146. |
|
This ran fine for me today, so maybe the Mongoose issue has been fixed? We'll see how the build behaves. |
|
Darn, no luck. Need to reproduce this locally, then, to get it fixed. |
|
I believe we will have to update our tests/error strings to comply with the update. |
|
Yeah. That's what I'm trying to reproduce locally. The one time my integration tests ran, they threw no errors of this type, so I must not have the problematic Mongoose version. |
|
You have to update your packages locally to reproduce the errors, checkout
the branch, delete node modules and reinstall
Il 28 Giu 2017 10:59 PM, "Sabe Jones" <[email protected]> ha scritto:
… Yeah. That's what I'm trying to reproduce locally. The one time my
integration tests ran, they threw no errors of this type, so I must not
have the problematic Mongoose version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8766 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkAV_xpN9jH35AQCQs9JzQjU8dap9GDks5sIr7CgaJpZM4NpKzR>
.
|
|
Got that step done. Integration tests aren't running at all for me locally, though, so still got some figuring out to do. :sigh: |
|
This should use npm 5.1.0 when merged |
|
This is still giving me trouble. If I update to npm@5, my integration tests time out connecting to Mongo. If I revert to npm@4, I can run integration tests just fine. |
|
That's strange :/ I'm not sure how to help if you have already tried reinstalling the entire node_modules folder after the upgrade. What version of mongo do you have installed? |
|
|
|
Hmm I have 3.4.4 so that's not the problem
2017-07-20 16:55 GMT+02:00 Sabe Jones <[email protected]>:
… MongoDB shell version v3.4.6
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8766 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkAV_MzzhwOoPEmTjTifbbbMZp6Tbblks5sP2pGgaJpZM4NpKzR>
.
--
Matteo Pagliazzi - paglias.net
|
|
@SabreCat what if we try another approach? Let's first update mongoose to the newest version and fix the tests with npm 4 and after that try to upgrade to npm 5 again |
|
Closing this as stale, but giving myself a To-Do to attempt the Mongoose upgrade you suggested. |
|
@SabreCat okay, can you reopen when mongoose is upgraded? |
No description provided.