Use simplest possible query for cron script #15457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the Group Plan scheduled script performed a MongoDB query filtering on both the existence of
purchased.plan.customerId
and an$or
between several possible states ofpurchased.plan.dateTerminated
that were valid for an active subscription. This operation was not performant, leading to a high number of scanned document keys and ultimately queries taking ten seconds or more to complete.Now, we perform the minimal query for existence of
purchased.plan.customerId
, which should be quick to resolve using a sparse index. Then within the script, after retrieving each group, we check whether itspurchased.plan.dateTerminated
indicates an expired sub. If so, we clear out thepurchased.plan.customerId
and move on to the next, so we can rely on the main query to exclude that group in future runs.