Extend the font metadata in accordance with the 2024 targets #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanUkhov
commented
Jun 27, 2024
| @@ -1,21 +1,22 @@ | |||
| pylint | |||
There was a problem hiding this comment.
Just sorting and adding black.
IvanUkhov
commented
Jun 27, 2024
| @@ -36,6 +36,9 @@ jobs: | |||
| python3 -m pip install --upgrade pip | |||
| pip3 install -r .github/workflows/requirements.txt | |||
|
|
|||
| - name: Analysing the code with Black | |||
| run: black --include font --check . | |||
There was a problem hiding this comment.
Apply only to font-related files to begin with. This is what I intend to touch in this PR.
|
Other than formatting and tests, is the only functional change that "head" was added to the output? |
|
Yes, the head is the only change from that perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.google.com/document/d/1ljEHbDvXComXnW5s_EXZ0nM3_JCLnYr28Xrcf0YYtP8.