-
-
Notifications
You must be signed in to change notification settings - Fork 297
Move tool testfiles to shared folder #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
commented
Jun 12, 2025
@@ -19,29 +19,36 @@ | |||
# -------------------------------------------------------------------- | |||
# Copy all the HDF5 files from the source directory into the test directory | |||
# -------------------------------------------------------------------- | |||
set (LIST_REPACK_TEST_FILES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list mixed reference .dat
files and HDF5 files, so I split it to distinguish the types of files
byrnHDF
approved these changes
Jun 13, 2025
lrknox
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Testing
Code in test or testpar directories, GitHub workflows
Component - Tools
Command-line tools like h5dump, includes high-level tools
Priority - 2. Medium
It would be nice to have this in the next release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move HDF5 files used by tools tests from individual
tools/test/<tool>/testfiles
folders to a sharedtools/test/testfiles
. This removes several cases where the same reference file existed in different folders.Resolves #5588