Skip to content

Move tool testfiles to shared folder #5597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 17, 2025
Merged

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Jun 12, 2025

Move HDF5 files used by tools tests from individual tools/test/<tool>/testfiles folders to a shared tools/test/testfiles. This removes several cases where the same reference file existed in different folders.

Resolves #5588

@mattjala mattjala requested a review from byrnHDF June 12, 2025 19:38
@mattjala mattjala added the Priority - 2. Medium It would be nice to have this in the next release label Jun 12, 2025
@mattjala mattjala added the Component - Tools Command-line tools like h5dump, includes high-level tools label Jun 12, 2025
@mattjala mattjala added the Component - Testing Code in test or testpar directories, GitHub workflows label Jun 12, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in HDF5 - TRIAGE & TRACK Jun 12, 2025
@@ -19,29 +19,36 @@
# --------------------------------------------------------------------
# Copy all the HDF5 files from the source directory into the test directory
# --------------------------------------------------------------------
set (LIST_REPACK_TEST_FILES
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list mixed reference .dat files and HDF5 files, so I split it to distinguish the types of files

@lrknox lrknox merged commit 6beb047 into HDFGroup:develop Jun 17, 2025
70 checks passed
@github-project-automation github-project-automation bot moved this from To be triaged to Done in HDF5 - TRIAGE & TRACK Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools Priority - 2. Medium It would be nice to have this in the next release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Tool test files should not be tool specific
3 participants