Don't fail when --configuration-cache is used. #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonomousapps
commented
Jun 14, 2022
autonomousapps
commented
Jun 14, 2022
autonomousapps
commented
Jun 14, 2022
gradle-plugin/src/test/kotlin/proguard/gradle/GradlePluginIntegrationTest.kt
Show resolved
Hide resolved
autonomousapps
commented
Jun 14, 2022
mrjameshamilton
suggested changes
Jun 29, 2022
|
The build fails because of a toolchains issue, which should be solved in 7.5 according to the issue gradle/gradle#20369 |
…would break in Gradle 8.0.
mrjameshamilton
force-pushed
the
trobalik.configuration-cache-support
branch
from
249c4e8 to
0b4c436
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@autonomousapps thanks for the PR! I've updated the Gradle version to 7.4.2 in ProGuard separately due to this issue. I've rebased and made a few modifications to this PR as well. |
|
@mrjameshamilton thank you! Sorry I didn't get back to you sooner, but it's been busy at work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #254 (but does not quite resolve it).