chore: add post commit script #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new post-commit script to automate changeset markdown creation after commits. Key changes include:
- Implementing functions to obtain the last commit details (ID, message, and file list).
- Parsing workspace packages from a YAML file and linking committed files to their respective workspace.
- Composing and writing a changeset markdown file, then auto-committing the changes.
Files not reviewed (2)
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
| const lastCommitMessage = await getLastCommitMessage() | ||
| const matchedChangeset = await getMatchedChangeset(lastCommitMessage) | ||
| if (!matchedChangeset) | ||
| return console.warn(`The commit message "${lastCommitMessage}" does not match any angular changeset type.`) |
There was a problem hiding this comment.
The warning message incorrectly refers to 'angular changeset type'. Consider updating it to reflect the general changeset logic used by the script.
Suggested change
| return console.warn(`The commit message "${lastCommitMessage}" does not match any angular changeset type.`) | |
| return console.warn(`The commit message "${lastCommitMessage}" does not match any recognized changeset type.`) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
scripts/post-commit.ts
Outdated
|
|
||
| console.log(`${workspaceCommittedFiles.map(v => k.dim(`${k.green(`[${v.workspace ? '✓' : '✗'}]`)} ${path.relative(process.cwd(), v.filePath)}: detected workspace: ${v.workspace?.folderPath ? path.relative(process.cwd(), v.workspace.folderPath) : 'null'}`)).join('\n')}`) | ||
| if (workspaceCommittedFiles.every(v => v.workspace === null)) | ||
| return console.warn(k.yellow(`The commit "${lastCommitMessage}" has not files in the workspace.`)) |
There was a problem hiding this comment.
The warning message contains a grammatical error ('has not files'); consider changing it to 'has no files'.
Suggested change
| return console.warn(k.yellow(`The commit "${lastCommitMessage}" has not files in the workspace.`)) | |
| return console.warn(k.yellow(`The commit "${lastCommitMessage}" has no files in the workspace.`)) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.