Skip to content

feat: expose reflector to main package #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

Conversation

Groupguanfang
Copy link
Owner

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 18, 2025 02:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the reflector to the main package by creating re-export files for various bundlers and environments. Key changes include:

  • Adding new entry points (e.g., webpack, vite, rspack, rollup, nuxt, etc.) that import and export the reflector module.
  • Updating the tsdown configuration in the NestJS fixture to reference the new reflector path.
  • Including a changeset documenting the feature change.

Reviewed Changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/unioc/src/webpack.ts Exports reflector for webpack integration
packages/unioc/src/reflector.ts Re-exports the core reflector module
packages/unioc/src/reflector-vite.ts Exports reflector for vite integration
packages/unioc/src/reflector-types.ts Re-exports reflector types
packages/unioc/src/reflector-rspack.ts Exports reflector for rspack integration
packages/unioc/src/reflector-rollup.ts Exports reflector for rollup integration
packages/unioc/src/reflector-rolldown.ts Exports reflector for rolldown integration
packages/unioc/src/reflector-nuxt.ts Exports reflector for nuxt integration
packages/unioc/src/reflector-farm.ts Exports reflector for farm integration
packages/unioc/src/reflector-esbuild.ts Exports reflector for esbuild integration
packages/unioc/src/reflector-client.ts Re-exports reflector client utilities
packages/unioc/src/reflector-astro.ts Exports reflector for astro integration
fixtures/nestjs/tsdown.config.ts Updates the import path for reflector in the tsdown config
.changeset/fifty-seas-dig.md Documents the new feature exposing reflector
Files not reviewed (2)
  • packages/unioc/package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

import { defineConfig } from 'tsdown'
import Reflector from 'unioc/reflector-rolldown'
Copy link
Preview

Copilot AI Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module reference is inconsistent with other imports which use '@unioc/...'. Consider correcting the path to '@unioc/reflector/rolldown' for consistency.

Suggested change
import Reflector from 'unioc/reflector-rolldown'
import Reflector from '@unioc/reflector/rolldown'

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@Groupguanfang Groupguanfang merged commit 2abff83 into v1 Apr 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants