feat: update reflector (#89) #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- package.json: Language not supported
- packages/core/reflector/package.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
fixtures/reflector/main.ts:16
- Class name 'testValue' does not follow standard PascalCase naming conventions. Consider renaming it to 'TestValue' for improved readability and consistency.
export class testValue<T> {}
| if (typeof Reflect.metadata === 'function') | ||
| return Reflect.metadata(metadataKey, metadataValue)(_target, ctx, ...args) | ||
|
|
||
| throw new Error('[UNIOC] Cannot find metadata context, current environment is in legacy mode, please import `reflect-metadata` polyfill. if you want to using stage3 mode, please set `experimentalDecorators` to `true` in your tsconfig.json.') |
There was a problem hiding this comment.
[nitpick] The error message contains grammatical inconsistencies; consider rephrasing it by capitalizing the sentence and replacing 'if you want to using stage3 mode' with 'If you want to use stage3 mode'.
Suggested change
| throw new Error('[UNIOC] Cannot find metadata context, current environment is in legacy mode, please import `reflect-metadata` polyfill. if you want to using stage3 mode, please set `experimentalDecorators` to `true` in your tsconfig.json.') | |
| throw new Error('[UNIOC] Cannot find metadata context, current environment is in legacy mode. Please import `reflect-metadata` polyfill. If you want to use stage3 mode, please set `experimentalDecorators` to `true` in your tsconfig.json.') |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.