Skip to content

feat: add unioc reflector (#89) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

feat: add unioc reflector (#89) #90

merged 1 commit into from
Apr 17, 2025

Conversation

Groupguanfang
Copy link
Owner

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 04:27
@Groupguanfang Groupguanfang changed the title docs(changeset): feat: add unioc reflector (#89) feat: add unioc reflector (#89) Apr 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 20 out of 24 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • fixtures/reflector/package.json: Language not supported
  • fixtures/reflector/tsconfig.json: Language not supported
  • package.json: Language not supported
  • packages/core/reflector/package.json: Language not supported
Comments suppressed due to low confidence (2)

packages/core/reflector/src/core/ast.ts:9

  • [nitpick] The inline self-invoking function used as a fallback in transformTSTypeName reduces readability; consider extracting its logic into a named helper function to improve clarity.
return typeName.typeAnnotation ? transformTSType(typeName.typeAnnotation) : `(() => { try { return ${typeName.name} } catch (e) { return Object } })()`

packages/core/reflector/src/index.ts:22

  • [nitpick] Consider using a consistent async/await style instead of mixing await with .then() to improve readability; for example, assign the awaited result to a variable and then return the transformed object.
return await transform(parseSync(id, code), code).then(s => ({

@Groupguanfang Groupguanfang merged commit 0e4f713 into v1 Apr 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants