feat: implement guard support (#24) #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/adapter/adapter-nestjs/test/guard.test.ts:80
- The test case for 'should use guard with filter' includes commented-out expectations for the filtered response. Consider uncommenting the expectation or adding a clear mechanism to verify the custom response to avoid false negatives.
// .expect({
| @@ -24,7 +44,18 @@ export class EndingHandler { | |||
| ctx.response.end(await this._toSendableString(result.value)) | |||
| } | |||
| else { | |||
| ctx.response.statusCode = 500 | |||
| if (result.error instanceof HttpException) { | |||
There was a problem hiding this comment.
After sending a response for the HttpException, the code continues to call ctx.response.end again. Add a return statement immediately after sending the response to prevent double sending.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Groupguanfang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.