Skip to content

Add /grim history <player> #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: 2.0
Choose a base branch
from
Open

Add /grim history <player> #2023

wants to merge 24 commits into from

Conversation

AbdisKiosk
Copy link
Contributor

See #1782

AbdisKiosk and others added 23 commits November 9, 2024 22:56
@AbdisKiosk
Add option to log violations
d4b3cb9
@AbdisKiosk
Add /grim history command
79e2cca
@AbdisKiosk @ManInMyVan
Follow coventions
53c0f23 
Co-authored-by: ManInMyVan <[email protected]>
@AbdisKiosk
Remove unused getters
b6759e9
@AbdisKiosk
Make messages configurable
5578d12
@AbdisKiosk
make entries per page configurable
9a086d0
@AbdisKiosk
fix subcommand alias
ce6152a
@AbdisKiosk
add command to messages
422c847
@AbdisKiosk
synchronize writes to avoid sqlite_misuse error
07d389d
@AbdisKiosk
add history messages to all lang files
5070bdd
@AbdisKiosk
add mysql compatability to violation database
60e0b1b
@AbdisKiosk
add mysql compatability to violation database
2d14e40
@AbdisKiosk
add grim history in help command for all languages
458bfcb
@AbdisKiosk
change colorcodes from § to & for grim history strings
6790ee4
@AbdisKiosk
avoid sync usage of Bukkit.getOfflinePlayer(string)
5dd663e
@AbdisKiosk
add tab completion for online players in grim history
cb9b311
@AbdisKiosk
remove test
e2d38d7
@AbdisKiosk @ManInMyVan
Follow coventions
be006d1 
Co-authored-by: ManInMyVan <[email protected]>
@AbdisKiosk
revert file permission change in gradlew
5d33aa3
@AbdisKiosk
add 'server' field to grim history
42257a3
@AbdisKiosk
Merge branch '2.0' into 2.0
7aff253
@AbdisKiosk
Merge remote-tracking branch 'upstream/2.0' into 2.0
8891aae 
# Conflicts:
#	src/main/java/ac/grim/grimac/manager/init/start/CommandRegister.java
#	src/main/resources/config/zh.yml
#	src/main/resources/messages/de.yml
@AbdisKiosk
fix typo in build.gradle.kts
a7803ab
SamB440
SamB440 reviewed Feb 23, 2025
View reviewed changes
Copy link
Contributor

@SamB440 SamB440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have an option on whether it's enabled or not, and have it disabled by default.

@AbdisKiosk
Copy link
Contributor Author

I think we should have an option on whether it's enabled or not, and have it disabled by default.

You need to add it in punishments.yml before it is logged

@overkidding
Copy link
Contributor

I think we should have an option on whether it's enabled or not, and have it disabled by default.

You need to add it in punishments.yml before it is logged

I think he meant to also prevent from connecting to mysql when they do not want this enabled

@AbdisKiosk
Copy link
Contributor Author

I think we should have an option on whether it's enabled or not, and have it disabled by default.

You need to add it in punishments.yml before it is logged

I think he meant to also prevent from connecting to mysql when they do not want this enabled

It is sqlite by default, which uses a negligible amount of memory. But I guess I could make it configurable if he thinks it's a good idea

@overkidding
Copy link
Contributor

It is sqlite by default, which uses a negligible amount of memory.

still someone could not want any database enabled

ManInMyVan
ManInMyVan requested changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@ManInMyVan ManInMyVan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should keep placeholders (ie tps, ping)

@AbdisKiosk
Copy link
Contributor Author

Will this be merged before or after axionizes platform independence changes?

@Axionize
Copy link
Contributor

Axionize commented Mar 3, 2025 •
edited
Loading

Likely after since merging it now would be pointless (instant rewrite of command requried)

ManInMyVan
ManInMyVan requested changes May 4, 2025
View reviewed changes
Copy link
Contributor

@ManInMyVan ManInMyVan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase/merge

src/main/java/ac/grim/grimac/manager/violationdatabase/Violation.java
import java.util.UUID;

@Data
public class Violation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be a record

@ManInMyVan ManInMyVan added the status: rebase required The pull request needs rebasing onto the merge branch label May 4, 2025
@ManInMyVan ManInMyVan linked an issue May 4, 2025 that may be closed by this pull request
Previous alerts history #2016
Open
@AbdisKiosk
Copy link
Contributor Author

rebase/merge

I'll wait until platform independence is completed

@ManInMyVan
Copy link
Contributor

rebase/merge

I'll wait until platform independence is completed

it's already been merged into 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamB440 SamB440 SamB440 left review comments

@ManInMyVan ManInMyVan ManInMyVan requested changes

Assignees
No one assigned
Labels
status: rebase required The pull request needs rebasing onto the merge branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previous alerts history
5 participants
@AbdisKiosk @overkidding @Axionize @ManInMyVan @SamB440