Skip to content

cleanup #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.0
Choose a base branch
from
Open

cleanup #1966

wants to merge 4 commits into from

Conversation

ManInMyVan
Copy link
Contributor

No description provided.

@ManInMyVan ManInMyVan requested a review from SamB440 January 26, 2025 00:52
Copy link
Contributor

@SamB440 SamB440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against the collision box changes. It makes sense with inheritance to keep the separate classes. IMO it also looks prettier to do new. The NONE field is also very bad convention wise.

@ManInMyVan ManInMyVan requested a review from SamB440 January 26, 2025 23:29
@ManInMyVan ManInMyVan added the status: review required The pull request is awaiting review label Feb 2, 2025
@ManInMyVan ManInMyVan added the status: rebase required The pull request needs rebasing onto the merge branch label Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rebase required The pull request needs rebasing onto the merge branch status: review required The pull request is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants