Skip to content

Fix AirLiquidPlace false flag when place blocks in falling sand #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Dg32z
Copy link
Contributor

@Dg32z Dg32z commented Nov 8, 2024

No description provided.

@Dg32z Dg32z changed the title Fixed AirLiquidPlace false flag when place blocks in falling sand Fix AirLiquidPlace false flag when place blocks in falling sand Nov 8, 2024
@Axionize
Copy link
Contributor

Axionize commented Nov 8, 2024

Feel free to put this in your fork if you want but this is not an airplace fix and will not be merged into Grim. You are simply exempting sand blocks. Gravel is a similar falling block yet you don't have a check for it? What about handling falling blocks generically, as falling blocks can be of any blocktype in Minecraft.

Not to mention you aren't addressing the fundamental cause of these falses at all...

I appreciate that you're willing to contribute but expect comparable amounts of work to what I put into LineOfSightPlace #1679 from the start to what it is now before this can be considered beyond even a draft.

@Dg32z Dg32z closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants