Skip to content

feat: add explain options to query request #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Mar 24, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#4408

What's changed and what's your intention?

This PR adds ExplainOptions to the QueryContext. The option currently only has a verbose flag, but we may extend it to store more options on demand.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@evenyag evenyag requested review from WenyXu, discord9 and waynexia March 24, 2025 09:21
Copy link
Contributor

@discord9 discord9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge until GreptimeTeam/greptimedb#5763 is ready to merge

@MichaelScofield MichaelScofield merged commit 97e298d into main Mar 25, 2025
6 checks passed
@MichaelScofield MichaelScofield deleted the feat/verbose-flag branch March 25, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants