-
Notifications
You must be signed in to change notification settings - Fork 53
feat: port over /auth #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port over /auth #472
Conversation
@yunchipang did you finish all test and past them? |
I don't currently see a tests folder on the typescript branch and I'm not sure what the preferred approach is (I was messaging @Kpoke ). Should I create a If you don't mind, could I slack you for more detailed questions? tysm! |
@dadiorchen @Kpoke tests for root and |
it('should login with valid credentials', async () => { | ||
const staticApiKey = 'FORTESTFORTESTFORTESTFORTESTFORTEST'; | ||
|
||
const response = await request(app.getHttpServer()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of an integration test than it is a unit test.
Let's have a tests folder in the root folder which will house the integration tests like this https://github.com/Greenstand/treetracker-wallet-api/tree/master/__tests__
and the unit tests can be in the auth folder, like this https://github.com/Greenstand/treetracker-wallet-api/blob/master/server/services/AuthService.spec.js
@@ -0,0 +1,22 @@ | |||
export enum AUTH_EVENTS { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be in the event module
Description
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
What is the new behavior?
Breaking change
Does this PR introduce a breaking change?
Other useful information