Skip to content

Update published documentation to .NET 8 #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2024

Conversation

nttDamien
Copy link
Contributor

Pull Request

Issue Number: #506

Summary

updating .NET refecences older than 8

Changes

  • also updated a broken link

Checklist

  • [NA ] Local Tests Passing?
  • [ NA] CICD and Pipeline Tests Passing?
  • [ NA] Added any new Tests?
  • Documentation Updates Made?
  • [ NA] Are there any API Changes? If yes, please describe below.
  • [ NA] This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No

Is this a breaking change?

No

Anything else?

Thanks to Sophie for all the prep work...

This PR Closes #506

nttDamien added 3 commits May 8, 2024 14:50
update older .Net reference 

Signed-off-by: nttDamien <[email protected]>
Copy link
Collaborator

@danuw danuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @nttDamien - was that all of it btw (i.e. just in the enablement.md doc)?

@danuw
Copy link
Collaborator

danuw commented May 13, 2024

Hi @nttDamien I think the only last 2 references I can find we could just rid are in those 2 links

[the Secret Manager tool](https://learn.microsoft.com/en-us/aspnet/core/security/app-secrets?view=aspnetcore-6.0&tabs=windows#secret-manager)

replace https://learn.microsoft.com/en-us/aspnet/core/security/app-secrets?view=aspnetcore-6.0&tabs=windows#secret-manager with https://learn.microsoft.com/en-us/aspnet/core/security/app-secrets?tabs=windows#secret-manager

and ...

> [default .NET configuration](https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-6.0#default-application-configuration-sources)

replace https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-6.0#default-application-configuration-sources with

[default .NET configuration](https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?#default-application-configuration-sources`

I checked, it defaults to the latest GA version (so 8 at the mo) and I think we can leave it going forward...

Could you apply these 2 as well so I can merge please?

Thanks again for this already

2 missed references...

Signed-off-by: nttDamien <[email protected]>
@nttDamien
Copy link
Contributor Author

https://learn.microsoft.com/en-us/aspnet/core/security/app-secrets?tabs=windows#secret-manager

I checkd the files suggested by Sophie and for most no change was required. Although I doubt myself now that you found two places I missed ...

@danuw
Copy link
Collaborator

danuw commented May 14, 2024

@nttDamien I checked everything for key terms and this was the last thing I could find just using 6.0... I think if we update these 2 things we should be good - (we are probably good without it too given you can change the version when you get to that page)
Lets discuss this morning

Copy link
Collaborator

@danuw danuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @nttDamien

@danuw danuw merged commit 27f41df into Green-Software-Foundation:dev May 14, 2024
@danuw danuw mentioned this pull request Jul 12, 2024
2 tasks
@vaughanknight vaughanknight mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Check our published documentation to identify any references to .NET7
2 participants