-
Notifications
You must be signed in to change notification settings - Fork 106
Update published documentation to .NET 8 #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update older .Net reference Signed-off-by: nttDamien <[email protected]>
Signed-off-by: nttDamien <[email protected]>
Signed-off-by: nttDamien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you @nttDamien - was that all of it btw (i.e. just in the enablement.md doc)?
Hi @nttDamien I think the only last 2 references I can find we could just rid are in those 2 links
replace and ...
replace
I checked, it defaults to the latest GA version (so 8 at the mo) and I think we can leave it going forward... Could you apply these 2 as well so I can merge please? Thanks again for this already |
2 missed references... Signed-off-by: nttDamien <[email protected]>
I checkd the files suggested by Sophie and for most no change was required. Although I doubt myself now that you found two places I missed ... |
@nttDamien I checked everything for key terms and this was the last thing I could find just using 6.0... I think if we update these 2 things we should be good - (we are probably good without it too given you can change the version when you get to that page) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks @nttDamien
Pull Request
Issue Number: #506
Summary
updating .NET refecences older than 8
Changes
Checklist
Are there API Changes?
No
Is this a breaking change?
No
Anything else?
Thanks to Sophie for all the prep work...
This PR Closes #506