Infrastructure for accessing elastic/opensearch hosts used in rest clients #22185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danotorrey
approved these changes
Apr 4, 2025
Comment on lines
50
to
51
| import org.graylog2.configuration.IndexerDiscoveryModule; | ||
| import org.graylog2.configuration.PathConfiguration; |
There was a problem hiding this comment.
Not part of the changes in this PR, but these appear to be unused, so maybe you could remove them.
There was a problem hiding this comment.
I just rebased the branch and these imports are now needed. Maybe this was just an out-of-sync state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Elastic/opensearch clients are the single source of truth when it comes to a list of indexer hosts. This PR is making this information readily available for every use case where we need to access these hosts directly, without the client.
Motivation and Context
There are some places in graylog codebease where we need to access indexer hosts directly. Some are related to notifications about changed indexer version (and compatibility with our client libs), some are alternative opensearch clients, like for anomaly detection. These places are regularly triggering requests to indexer hosts and need to know which are valid and accessible.
How Has This Been Tested?
Manually, existing integration tests
Screenshots (if appropriate):
Types of changes
Checklist: