-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(verify): use container name from configuration in verify tests #9753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, I tested it locally and it seems to be working. It looks like an integration test is failing however. |
Signed-off-by: Suleiman Dibirov <[email protected]>
Signed-off-by: Suleiman Dibirov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like container name is required for verify actually, so this would solve the problem completely.
Something else to consider - wdyt about extracting the name checking logic in getContainerName to run in the s.Go()? If we check the container name existence every time before createAndRunContainer is called, then it should be creating the new ones with diff UUIDs.
I think it's also a good solution, it'll reduce a bit the execution speed, because you have to call the docker client in sync mode multiple times, but I think it should be okay, because it shouldn't take a lot of time and it'll make sense if a user has tons of containers. And, I think it'll be better to extract the |
I'm going to merge this PR for now + create another issue to unify the verify + custom actions logic. I'm still not sure exactly why everything is working for custom actions (likely has to do with how it gets called + the threads start running), so refactoring might be more complicated than anticipated. |
Fixes: #9747
Description
Add using container name from configuration in verify tests