Skip to content

chore: remove v1 config package and move it to latest package. #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

gsquared94
Copy link
Contributor

Consistently set alias latest for importing "github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/latest/v1".
This will reduce diff for PR #7242

@gsquared94 gsquared94 requested a review from MarlonGamez April 12, 2022 11:32
@gsquared94 gsquared94 requested a review from a team as a code owner April 12, 2022 11:32
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #7290 (8161108) into main (290280e) will decrease coverage by 2.00%.
The diff coverage is 57.29%.

@@            Coverage Diff             @@
##             main    #7290      +/-   ##
==========================================
- Coverage   70.48%   68.48%   -2.00%     
==========================================
  Files         515      560      +45     
  Lines       23150    26507    +3357     
==========================================
+ Hits        16317    18153    +1836     
- Misses       5776     7098    +1322     
- Partials     1057     1256     +199     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <0.00%> (-1.85%) ⬇️
cmd/skaffold/app/cmd/filter.go 25.00% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <46.15%> (+0.24%) ⬆️
cmd/skaffold/app/cmd/diagnose.go 70.27% <50.00%> (+5.40%) ⬆️
... and 231 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@MarlonGamez
Copy link
Contributor

@gsquared94, do we want to move the package up one level as well? latest/v1 -> latest
If we do the same on the v2 branch then I think we can reduce the diff even more

@gsquared94
Copy link
Contributor Author

@gsquared94, do we want to move the package up one level as well? latest/v1 -> latest If we do the same on the v2 branch then I think we can reduce the diff even more

done.

@gsquared94 gsquared94 changed the title refactor: consistent alias for import schema/latest/v1 chore: remove v1 config package and move it to latest package. Apr 12, 2022
@gsquared94 gsquared94 changed the title chore: remove v1 config package and move it to latest package. chore: remove v1 config package and move it to latest package. Apr 12, 2022
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsquared94 This looks good to me, on the v2 branch when we do this same change I think we can keep move up latest/v2 to latest, and keep the latest/v1 package where it is so we can reference when we need to.

Do you want me to go ahead with that change, or would you like to work on it?

@gsquared94 gsquared94 merged commit 88a27ab into GoogleContainerTools:main Apr 12, 2022
bskaplan added a commit to bskaplan/skaffold that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants