Skip to content

Expose jib.from.platforms as property. #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 16, 2021
Merged

Expose jib.from.platforms as property. #3526

merged 8 commits into from
Dec 16, 2021

Conversation

ls-urs-keller
Copy link
Contributor

@ls-urs-keller ls-urs-keller commented Dec 11, 2021 •
edited by chanseokoh
Loading

Feature request: fixes #2742

@ls-urs-keller ls-urs-keller mentioned this pull request Dec 13, 2021
Closed
@zhumin8
Copy link
Contributor

zhumin8 commented Dec 13, 2021

Thanks for opening the PR !
The CLA check is failing. Please check the details here, and sign the CLA so that we can review and accept your contribution!

@ls-urs-keller
Copy link
Contributor Author

ls-urs-keller commented Dec 15, 2021 •
edited by chanseokoh
Loading

Thanks for opening the PR ! The CLA check is failing. Please check the details

My mistake https://cla.developers.google.com/clas used my default Google account, I didn't pay attention to it, should be OK now.

chanseokoh
chanseokoh reviewed Dec 15, 2021
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your contribution.

Could you add some tests in JibPluginConfigurationTest? Pretty trivial to do so if you look at the existing tests.

And, any chance you're interested in enabling this for Gradle? Not that I'm demanding, because it will do require your time.

@ls-urs-keller ls-urs-keller force-pushed the expose_jib_from_platforms_property branch from 96e8c43 to 1840cd2 Compare December 16, 2021 10:21
@ls-urs-keller
Copy link
Contributor Author

Awesome! Thanks for your contribution.

Could you add some tests in JibPluginConfigurationTest? Pretty trivial to do so if you look at the existing tests.

And, any chance you're interested in enabling this for Gradle? Not that I'm demanding, because it will do require your time.

I added it although I only tested it through unit tests.

chanseokoh
chanseokoh approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time! I've fixed an issue, updated docs, and refactored test code. Will merge this after checking a few things.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

85.2% 85.2% Coverage
0.0% 0.0% Duplication

@chanseokoh chanseokoh merged commit 8dc607c into GoogleContainerTools:master Dec 16, 2021
@ls-urs-keller ls-urs-keller deleted the expose_jib_from_platforms_property branch December 17, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

@mpeddada1 mpeddada1 Awaiting requested review from mpeddada1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<platform> configuration should be configurable with system properties
4 participants
@ls-urs-keller @zhumin8 @chanseokoh @kokoro-team