Fix root build.gradle being reported in skaffold init for multi-module projects #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
approved these changes
Oct 23, 2019
chanseokoh
pushed a commit
that referenced
this pull request
Oct 25, 2019
* Use artifact ID instead of project name in SkaffoldInitMojo (#2090) * Fix root build.gradle being reported in skaffold init for multi-module projects (#2091) * Enhance TestWebServer and some cleanups (#2092) * Unzipping WAR file to a temporary folder to solve #1727 * Creating libs folder during setup, since we cant commit empty folders * Code cleaning to adher to the recommendations * Deleted unused Task. Formatted code. Changed the tests to use webapp name and resolve to parent folder instead of using libs * Fix tests * Clean up * Restore original * Remove debug output * Remove redundant jib-exploded-war
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an issue that was fixed in #1974 on the maven side, but I forgot to change the gradle side as well.
This PR also updates the changelog for #2090.